-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/fix clickhouse with druid #566
Merged
wu-sheng
merged 25 commits into
apache:main
from
gzlicanyi:feature/fix-clickhouse-with-druid
Jun 30, 2023
Merged
Feature/fix clickhouse with druid #566
wu-sheng
merged 25 commits into
apache:main
from
gzlicanyi:feature/fix-clickhouse-with-druid
Jun 30, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…SpringCloudGateway/sendRequest"
It is better you could rebase your commits. They are too long. |
ok, I will do it next time. |
wu-sheng
approved these changes
Jun 30, 2023
yangyulely
pushed a commit
to yangyulely/skywalking-java
that referenced
this pull request
May 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
CHANGES
log.problem
Steps to reproduce
Using the following dependencies:
properties:
spring config:
Causes
The URLParser.parser() method in the PoolingAddDruidDataSourceInterceptor class does not support parsing ClickHouse URLs.
how to fix it
Add ClickHouse parsing to the jdbc-common plugin.