Support to trace redisson lock #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wu-sheng
reviewed
Jul 1, 2023
...ugin/src/main/java/org/apache/skywalking/apm/plugin/redisson/v3/RedissonLockInterceptor.java
Outdated
Show resolved
Hide resolved
wu-sheng
reviewed
Jul 1, 2023
...ugin/src/main/java/org/apache/skywalking/apm/plugin/redisson/v3/RedissonLockInterceptor.java
Outdated
Show resolved
Hide resolved
|
Please fix the code style of your test codes. |
wu-sheng
reviewed
Jul 1, 2023
...ugin/src/main/java/org/apache/skywalking/apm/plugin/redisson/v3/RedissonLockInterceptor.java
Outdated
Show resolved
Hide resolved
wu-sheng
reviewed
Jul 2, 2023
Comment on lines
37
to
41
| private static final AbstractTag<String> TAG_LOCK_NAME = Tags.ofKey("lock_name"); | ||
|
|
||
| private static final AbstractTag<String> TAG_LEASE_TIME = Tags.ofKey("lease_time"); | ||
|
|
||
| private static final AbstractTag<String> TAG_THREAD_ID = Tags.ofKey("thead_id"); |
There was a problem hiding this comment.
Are these duplicated? If so, please move them into a Tags class to avoid the duplication.
|
You need to fix CI first. |
wu-sheng
approved these changes
Jul 2, 2023
3 tasks
yangyulely
pushed a commit
to yangyulely/skywalking-java
that referenced
this pull request
May 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the documentation to include this new feature.
Tests(including UT, IT, E2E) are added to verify the new feature.
Update the
CHANGESlog.