fix jedis 2.x plugin bug and add test for redis cluster #580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wu-sheng
reviewed
Jul 10, 2023
| @Override | ||
| public void onConstruct(EnhancedInstance objInst, Object[] allArguments) throws Throwable { | ||
| HostAndPort hostAndPort = (HostAndPort) allArguments[0]; | ||
| objInst.setSkyWalkingDynamicField(hostAndPort.getHost() + ":" + hostAndPort.getPort()); |
There was a problem hiding this comment.
For a cluster, it has only one IP and port? Should it be ip1:port1,ip2:port...?
There was a problem hiding this comment.
the JedisCluster constructor support one server and multi server，this is for one，multi is org.apache.skywalking.apm.plugin.jedis.v3.JedisClusterConstructorWithListHostAndPortArgInterceptor
xu1009
changed the title
wu-sheng
approved these changes
Jul 10, 2023
|
@xu1009 Please clean the commit logs when do squashing. This one looks. |
|
ok，got it |
yangyulely
pushed a commit
to yangyulely/skywalking-java
that referenced
this pull request
May 25, 2024
* fix bug and add test for redist cluster * add test to flow --------- Co-authored-by: litexu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGESlog.