Bump up grpc #650
Bump up grpc #650
Conversation
|
rocketmq plugin is preventing us from upgrading grpc now |
|
Could you recheck the CI? |
👆 |
|
What do you mean? How a plugin blocks a lib upgrade? |
|
The log is better than hundreds of words:
https://github.com/apache/skywalking-java/actions/runs/7015220764/job/19084175721?pr=650#step:3:431 |
|
rocketmq sets a hard requirement of gRPC 1.53.0, upgrading our core grpc to >1.53.0 breaks maven dependency resolution |
| <exclusions> | ||
| <exclusion> | ||
| <groupId>io.grpc</groupId> | ||
| <artifactId>grpc-netty</artifactId> | ||
| </exclusion> | ||
| </exclusions> |
There was a problem hiding this comment.
I think we should exclude grpc from agent-core, rather than from this side?
There was a problem hiding this comment.
Why? GRPC is needed in agent side, how can we exclude it there?
There was a problem hiding this comment.
I think the agent plugin depends on the agent core lib, which has the gRPC dependency overriding the version.
We just need the RocketMQ plugin compiled. So, about exclude, I mean for this plugin, it could depend on agent-core with gRPC excluded. In the runtime, this plugin is using the user's gRPC, our gRPC and netty would have been shaded in another package already. So, we should be good by that.
| <dependency> | ||
| <groupId>org.apache.skywalking</groupId> | ||
| <artifactId>apm-agent-core</artifactId> | ||
| <version>${project.version}</version> | ||
| <scope>provided</scope> | ||
| <exclusions> | ||
| <exclusion> | ||
| <groupId>io.grpc</groupId> | ||
| <artifactId>grpc-netty</artifactId> | ||
| </exclusion> | ||
| </exclusions> |
CHANGESlog.