-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump up lombok version to 1.18.30 to support JDK21 #676
Conversation
Eh, but how did the agent pass GitHub action testing though..? or java agent hasn't been tested on jdk21 yet |
JDK21 is only tested for Spring 6.x scenario... |
I suppose you have to use JDK8 or 17 for those scenarios based on the workflows defined in the repo. For other cases, the situation is unknown. Even if you've bumped up lombok version, other dependencies may not work. |
Agree, I have the same question, is this bump up necessary for all tests. Because basically, different tests are not expected to run on locked JDK versions. Some of the lib, especially old released versions, will never be able to run on JDK 21. Even if it can be, it is either transparent or relies on a new release. |
The agent is ready, but the target libs may or may not, depending on the cases. |
I follow the advice of Java Agent Compiling porject and use JDK 21. I checked Github Action config, even if i use JDK 17, it is not all test case can run in JDK 17, most cases are in JDK1.8 environment. There is a little problem between documents and actual situation. Back to this pr, is there some others i need to do? |
The doc does not say anything about E2E. You MUST follow the steps in the workflow to run all E2E cases.
Exactly |
Close for now |
CHANGES
log.Fix compile problem when run scenario test.
Lombok version smaller than 1.18.30 is not support JDK21. This pr bump up lombok version to 1.18.30 to support JDK21.
Related PR: skywalking-agent-test-tool#57