Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump up lombok version to 1.18.30 to support JDK21 #676

Closed
wants to merge 2 commits into from

Conversation

OrezzerO
Copy link
Contributor

  • If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #.
  • Update the CHANGES log.

Fix compile problem when run scenario test.

Lombok version smaller than 1.18.30 is not support JDK21. This pr bump up lombok version to 1.18.30 to support JDK21.

Related PR: skywalking-agent-test-tool#57

@Superskyyy Superskyyy added this to the 9.2.0 milestone Mar 20, 2024
@Superskyyy
Copy link
Member

Superskyyy commented Mar 20, 2024

Eh, but how did the agent pass GitHub action testing though..? or java agent hasn't been tested on jdk21 yet

@lujiajing1126
Copy link
Contributor

Eh, but how did the agent pass GitHub action testing though..? or java agent hasn't been tested on jdk21 yet

JDK21 is only tested for Spring 6.x scenario...

@lujiajing1126
Copy link
Contributor

Fix compile problem when run scenario test.

I suppose you have to use JDK8 or 17 for those scenarios based on the workflows defined in the repo.

For other cases, the situation is unknown. Even if you've bumped up lombok version, other dependencies may not work.

@wu-sheng
Copy link
Member

Agree, I have the same question, is this bump up necessary for all tests. Because basically, different tests are not expected to run on locked JDK versions. Some of the lib, especially old released versions, will never be able to run on JDK 21. Even if it can be, it is either transparent or relies on a new release.

@wu-sheng
Copy link
Member

Eh, but how did the agent pass GitHub action testing though..? or java agent hasn't been tested on jdk21 yet

The agent is ready, but the target libs may or may not, depending on the cases.
This bump up is harmless, if you have to say. But this doesn't mean, all plugins can magically run on JDK 21 when the target libs can't by themselves.

@OrezzerO
Copy link
Contributor Author

I follow the advice of Java Agent Compiling porject and use JDK 21. I checked Github Action config, even if i use JDK 17, it is not all test case can run in JDK 17, most cases are in JDK1.8 environment. There is a little problem between documents and actual situation.

Back to this pr, is there some others i need to do?

@lujiajing1126
Copy link
Contributor

I follow the advice of Java Agent Compiling porject and use JDK 21. There is a little problem between documents and actual situation.

The doc does not say anything about E2E. You MUST follow the steps in the workflow to run all E2E cases.

I checked Github Action config, even if i use JDK 17, it is not all test case can run in JDK 17, most cases are in JDK1.8 environment.

Exactly

@wu-sheng
Copy link
Member

Close for now

@wu-sheng wu-sheng closed this Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants