Fixed issues in the MySQL component where the executeBatch method could result in empty SQL statements . #702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 1, 2024 14:30
Fixed an issue in the MySQL component where the executeBatch method could obtain SQL in certain scenarios, but the final SQL statement was empty. Fixed an issue in the MySQL component where SQL parameters were not collected in certain scenarios (e.g., executeBatch).
w2dp
changed the title
wu-sheng
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed an issue in the MySQL component where the executeBatch method could obtain SQL in certain scenarios, but the final SQL statement was empty.
The issue arises because the existing code defaults to using the first parameter of the enhanced method as the source of the SQL statement. However, the executeBatch method does not have any parameters. Given the previous problem where SQL could not be obtained from the cacheObject, this approach merely attempts to retrieve the SQL to the best extent possible, though perfect collection cannot be guaranteed.