Remove kafka-fetcher/default/createTopicIfNotExist (#12095)

apache · Apr 12, 2024 · 7701e42 · 7701e42
1 parent 13bb3f6
commit 7701e42
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 6 deletions.
diff --git a/docs/en/changes/changes.md b/docs/en/changes/changes.md
@@ -97,6 +97,7 @@
 * Fix `NullPointerException` in Istio ServiceEntry registry.
 * Remove unnecessary `componentIds` as series ID in the `ServiceRelationClientSideMetrics` and `ServiceRelationServerSideMetrics` entities.
 * Fix not throw error when part of expression not matched any expression node in the `MQE` and `PromQL.
+* Remove `kafka-fetcher/default/createTopicIfNotExist` as the creation is automatically since [#7326](https://github.com/apache/skywalking/issues/7326) (v8.7.0).
 
 #### UI
 

diff --git a/docs/en/setup/backend/configuration-vocabulary.md b/docs/en/setup/backend/configuration-vocabulary.md
@@ -225,7 +225,6 @@ The Configuration Vocabulary lists all available configurations provided by `app
 | -                       | -             | bootstrapServers                                                                                                                                                         | A list of host/port pairs to use for establishing the initial connection to the Kafka cluster.                                                                                                                                                                                                                                                                                                                                                                             | SW_KAFKA_FETCHER_SERVERS                              | localhost:9092                                                                               |
 | -                       | -             | namespace                                                                                                                                                                | Namespace aims to isolate multi OAP cluster when using the same Kafka cluster. If you set a namespace for Kafka fetcher, OAP will add a prefix to topic name. You should also set namespace in `agent.config`. The property is named `plugin.kafka.namespace`.                                                                                                                                                                                                             | SW_NAMESPACE                                          | -                                                                                            |
 | -                       | -             | groupId                                                                                                                                                                  | A unique string that identifies the consumer group to which this consumer belongs.                                                                                                                                                                                                                                                                                                                                                                                         | -                                                     | skywalking-consumer                                                                          |
-| -                       | -             | createTopicIfNotExist                                                                                                                                                    | If true, this creates Kafka topic (if it does not already exist).                                                                                                                                                                                                                                                                                                                                                                                                          | -                                                     | true                                                                                         |
 | -                       | -             | partitions                                                                                                                                                               | The number of partitions for the topic being created.                                                                                                                                                                                                                                                                                                                                                                                                                      | SW_KAFKA_FETCHER_PARTITIONS                           | 3                                                                                            |
 | -                       | -             | consumers                                                                                                                                                                | The number of consumers to create.                                                                                                                                                                                                                                                                                                                                                                                                                                         | SW_KAFKA_FETCHER_CONSUMERS                            | 1                                                                                            |
 | -                       | -             | enableNativeProtoLog                                                                                                                                                     | Enables fetching and handling native proto log data.                                                                                                                                                                                                                                                                                                                                                                                                                       | SW_KAFKA_FETCHER_ENABLE_NATIVE_PROTO_LOG              | true                                                                                         |

diff --git a/...java/org/apache/skywalking/oap/server/analyzer/agent/kafka/module/KafkaFetcherConfig.java b/...java/org/apache/skywalking/oap/server/analyzer/agent/kafka/module/KafkaFetcherConfig.java
@@ -42,11 +42,6 @@ public class KafkaFetcherConfig extends ModuleConfig {
      */
     private String groupId = "skywalking-consumer";
 
-    /**
-     * If true, create the Kafka topic when it does not exist.
-     */
-    private boolean createTopicIfNotExist = true;
-
     /**
      * The number of partitions for the topic being created.
      */