Skip to content

Commit

Permalink
Fix chores (#12000)
Browse files Browse the repository at this point in the history
  • Loading branch information
wu-sheng committed Mar 8, 2024
1 parent c5e0f5f commit 8c16fdd
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 6 deletions.
1 change: 1 addition & 0 deletions docs/en/changes/changes.md
Original file line number Diff line number Diff line change
Expand Up @@ -120,5 +120,6 @@
* Update postcss version to 8.4.33.
* Fix kafka topic name in exporter doc.
* Fix query-protocol.md, make it consistent with the GraphQL query protocol.
* Add `SWIP-5 Support ClickHouse Monitoring`.

All issues and pull requests are [here](https://github.com/apache/skywalking/milestone/202?closed=1)
12 changes: 6 additions & 6 deletions docs/en/swip/readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ The catalogs of a major change are listed as follows

**Q: Is Agent side feature or change considered a SWIP?**

A: Right now, SWIP targets on OAP and UI side changes. All agent side changes are pending on the reviews from the
A: Right now, SWIP targets OAP and UI side changes. All agent side changes are pending on the reviews from the
committers of those agents.

## SWIP Template
Expand All @@ -45,10 +45,10 @@ State your proposal in detail.
## Imported Dependencies libs and their licenses.

## Compatibility
Whether breaking configuration, storage structure, protocols.
Whether breaking configuration, storage structure, or protocols.

## General usage docs
This doesn't have to be final version, but help the reviews to understand how to use this new feature.
This doesn't have to be a final version, but helps the reviewers to understand how to use this new feature.
```

## SWIP Process
Expand All @@ -58,17 +58,17 @@ Here is the process for starting a SWIP.
1. Start a SWIP discussion at [GitHub Discussion Page](https://github.com/apache/skywalking/discussions/categories/swip)
with title `[DISCUSS] xxxx`.
2. Fill in the sections as described above in `SWIP Template`.
3. At least one SkyWalking committer commented on the discussion to show interests to adopt it.
3. At least one SkyWalking committer commented on the discussion to show interest in adopting it.
4. This committer could update this page to grant a **SWIP ID**, and update the title to `[SWIP-ID NO.] [DISCUSS] xxxx`.
5. All further discussion could happen on the discussion page.
6. Once the consensus is made by enough committer supporters, and/or through a mail list vote, this SWIP should be
added [here](./) as `SWIP-ID NO.md` and listed in the below as `Known SWIPs`.

All accepted and proposed SWIPs could be found in [here](https://github.com/apache/skywalking/discussions/categories/swip).
All accepted and proposed SWIPs can be found in [here](https://github.com/apache/skywalking/discussions/categories/swip).

## Known SWIPs

Next SWIP Number: 5
Next SWIP Number: 6

### Accepted SWIPs

Expand Down

0 comments on commit 8c16fdd

Please sign in to comment.