The index type BanyanDB.IndexRule.IndexType#TREE is removed (#12743)

apache · Nov 4, 2024 · 99162ef · 99162ef
1 parent 55600c6
commit 99162ef
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 9 deletions.
diff --git a/docs/en/changes/changes.md b/docs/en/changes/changes.md
@@ -15,6 +15,7 @@
 * Support async-profiler feature for performance analysis.
 * Add metrics value owner for metrics topN query result.
 * Add naming control for `EndpointDependencyBuilder`.
+* The index type `BanyanDB.IndexRule.IndexType#TREE` is removed. All indices are using `IndexType#INVERTED` now.
 
 #### UI
 

diff --git a/...r/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/topn/TopN.java b/...r/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/topn/TopN.java
@@ -38,7 +38,6 @@ public abstract class TopN extends Record implements ComparableStorageData {
     @Getter
     @Setter
     @Column(name = LATENCY, dataType = Column.ValueDataType.SAMPLED_RECORD)
-    @BanyanDB.IndexRule(indexType = BanyanDB.IndexRule.IndexType.TREE)
     private long latency;
     @Getter
     @Setter

diff --git a/...core/src/main/java/org/apache/skywalking/oap/server/core/storage/annotation/BanyanDB.java b/...core/src/main/java/org/apache/skywalking/oap/server/core/storage/annotation/BanyanDB.java
@@ -106,16 +106,12 @@ enum IndexType {
              * It's suitable for most tag indexing due to a better memory usage ratio and query performance.
              */
             INVERTED,
-            /**
-             * The `TREE` index could be better when there are high cardinalities, such as the `ID` tag and numeric duration tag.
-             * In these cases, it saves much memory space.
-             */
-            TREE;
         }
     }
 
     /**
-     * timestampColumn is to identify which column in {@link Record} is providing the timestamp(millisecond) for BanyanDB.
+     * timestampColumn is to identify which column in {@link Record} is providing the timestamp(millisecond) for
+     * BanyanDB.
      * BanyanDB stream requires a timestamp in milliseconds.
      *
      * @since 9.3.0

diff --git a/.../src/main/java/org/apache/skywalking/oap/server/core/storage/model/BanyanDBExtension.java b/.../src/main/java/org/apache/skywalking/oap/server/core/storage/model/BanyanDBExtension.java
@@ -51,12 +51,13 @@ public class BanyanDBExtension {
      * indexType is the type of index built for a {@link ModelColumn} in BanyanDB.
      *
      * @since 9.3.0
+     * @deprecated since 10.2. Only support {@link BanyanDB.IndexRule.IndexType#INVERTED} now. There was IndexType#TREE,
+     * but removed.
      */
-    @Getter
     private final BanyanDB.IndexRule.IndexType indexType;
 
     /**
-     *  A column belong to a measure's field.
+     * A column belong to a measure's field.
      */
     @Getter
     private final boolean isMeasureField;