Support output key parameters in the booting logs. #11506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # docs/en/changes/changes.md
wu-sheng
added
backend
wu-sheng
commented
Nov 6, 2023
| oap.external.grpc.host | 0.0.0.0 | ||
| oap.external.grpc.port | 11800 | ||
| oap.external.http.host | 0.0.0.0 | ||
| oap.external.http.port | 12800 |
There was a problem hiding this comment.
Suggested change
| oap.external.http.port | 12800 | |
| oap.external.http.port | 7788 |
This would change, once the receiver-sharing-server/gRPCPort is not 0 and activated.
There was a problem hiding this comment.
This is an explanation for the expected behavior, don't merge this.
kezhenxu94
previously approved these changes
Nov 6, 2023
wankai123
approved these changes
Nov 6, 2023
mrproliu
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGESlog.There are many logs at the DEBUG level and few logs at the INFO level. The raw text hides many important booting parameters in the haystack. So, I am proposing this new implementation to unify selected key parameters in one place and log out after the booting is down. This should be better formatted and easier to find and report.