Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SkyWalking Java Agent self observability dashboard #12622

Merged
merged 6 commits into from
Sep 16, 2024

Conversation

CzyerChen
Copy link
Contributor

#12595

  • Update the documentation to include this new feature.
  • If it's UI related, attach the screenshots below.

image
image

* The self observability of SkyWalking Java Agent,
* which provides the abilities to measure the tracing performance and error statistics of plugins.
*/
SO11Y_JAVA_AGENT(39, true);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need a UI PR for this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How your preview works without UI change? Is that possible?

@wu-sheng
Copy link
Member

I asked for a precision change for the agent side about duration cost by interceptor.
The current ms seems not precious enough, which would end all in 0.

My proposal is using nanosecond in agent and storage, but convert to ms or s as this is agent level metric.

@CzyerChen
Copy link
Contributor Author

I asked for a precision change for the agent side about duration cost by interceptor. The current ms seems not precious enough, which would end all in 0.

My proposal is using nanosecond in agent and storage, but convert to ms or s as this is agent level metric.

image

execution time storaged in ns and shown in ms.

@wu-sheng
Copy link
Member

These are costs of all plugin executions in this minute, right? Could we add some tips to explain this metric and others?

Or do we have a well explained document?

@wu-sheng
Copy link
Member

Please update the UI submodule. And I am going to merge apache/skywalking-java#716, could you add the e2e accordingly?

@wu-sheng
Copy link
Member

Please update the UI submodule. And I am going to merge apache/skywalking-java#716, could you add the e2e accordingly?

Merged.

@CzyerChen
Copy link
Contributor Author

Please update the UI submodule. And I am going to merge apache/skywalking-java#716, could you add the e2e accordingly?

OK

@wu-sheng
Copy link
Member

Suggestion, as we have Java agent in e2e, we could bump up java agent version, and add more checks to save resource costs of new e2e.

wankai123
wankai123 previously approved these changes Sep 15, 2024
Copy link
Member

@wankai123 wankai123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -86,7 +89,8 @@
"i": "2",
"type": "Widget",
"widget": {
"title": "Ignored Context Creation and Completion (Per Minute)"
"title": "Ignored Context Creation and Completion (Per Minute)",
"tips": "The number of created ignored contexts and finished ignored contexts per minute."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is not always per minute. When you pick several hours/days duration, the unit would be hour or day. You could just remove per minute for these tips.

@wu-sheng
Copy link
Member

There are some irrelevant test cases failing. Please recheck.

Besides #12622 (comment), I think this is good.

@wu-sheng
Copy link
Member

@CzyerChen @weixiang1862 This feature should be a good blog material. We could introduce what we add and why these are important.

@wu-sheng
Copy link
Member

Could you share why Kafka needs to be disabled?

@CzyerChen
Copy link
Contributor Author

Could you share why Kafka needs to be disabled?

Kafka test cases introduce the producer and consumer in Kafka Basic\Kafka Profiling, and now the agent adds self observability metrics by default, which will affect the original use case.

@wu-sheng
Copy link
Member

Why some new metrics would affect that?

I just want to be certain, we are bot breaking anything.

@weixiang1862
Copy link
Member

Why some new metrics would affect that?

I just want to be certain, we are bot breaking anything.

Java agent so11y meters generated agent so11y service traffic which make the order of service list changes and generated new agent so11y traffic.

Original test cases has many service traffic actual and expected checks, it is big change to fix all service expected data, so disable SW_METER_ACTIVE by default and actived it in meter test case to validate so11y changes.

@wu-sheng
Copy link
Member

So11y service is using the same service name and instance names, right?

I think we just build extra layer for each service?

@weixiang1862
Copy link
Member

So11y service is using the same service name and instance names, right?

I think we just build extra layer for each service?

Yes, the SO11Y_JAVA_AGENT service name and instance name is the same as GENERAL.

@weixiang1862
Copy link
Member

So11y service is using the same service name and instance names, right?

I think we just build extra layer for each service?

Metrics won't be effected, just service list values and order.

@wu-sheng wu-sheng merged commit d3f8fe8 into apache:master Sep 16, 2024
158 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend OAP backend related. feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants