Make ingress hostname configurable #764
Open
+68
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ovide a custom host name for a common ingress instead of the autogenerated one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the possibility to add an
hostNameto the ingress configuration of a given solrcloud instance as described in #667.The change is quit simple. Unfortunately, the
make preparestep failed for me at thefetch-licenses-liststep, so thedependency_licenses.csvstays empty in my case.To make the e2e-tests start / work, I also needed to change the
RAW_GINKGOcommand. Not sure if that is an issue only on my machine.Happy for any feedback!