Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOLR-17441 - Skip Unreadable Properties Early to Reduce Overhead #2694

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

heythm
Copy link
Contributor

@heythm heythm commented Sep 6, 2024

https://issues.apache.org/jira/browse/SOLR-17441

Description

Enhance the property introspection logic by skipping unreadable properties early in the process. By checking if desc.getReadMethod() is null before attempting to access the property, we can avoid unnecessary attempts to access properties that do not have a read method. This will reduce the number of exceptions thrown and the overhead associated with handling those exceptions, improving overall performance and stability.

Checklist

Please review the following and check all that apply:

  • I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
  • I have created a Jira issue and added the issue ID to my pull request title.
  • I have given Solr maintainers access to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation)
  • I have developed this patch against the main branch.
  • I have run ./gradlew check.
  • I have added tests for my changes.
  • I have added documentation for the Reference Guide

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant