SOLR-17444: Add Passage Sorting Option in UnifiedSolrHighlighter #2697
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-17444
Description
We will add the
passageSortComparator
option, introduced in theUnifiedHighlighter
in the Lucene 9.11 project, to the Solr highlighter parameters, enabling its functionality within Solr.For reference, here is the related Lucene project commit:
apache/lucene@8773725
Solution
PASSAGE_SORT
to HighlightParams to support the related functionality.UnifiedSolrHighlighter.SolrExtendedUnifiedHighlighter
class, I overrode thegetPassageSortComparator
method from the superclassUnifiedHighlighter
. ThePASSAGE_SORT
parameter from the request is parsed and the correspondingComparator<Passage>
object is used.Tests
Checklist
Please review the following and check all that apply:
main
branch../gradlew check
.