Fix StatusTool related issues on Windows #2798
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After #2712 the introduced changes were causing file permissions errors on Windows systems.
Solution
This PR extends the required permissions to all files for Windows, allowing it to run
wmic
without limitations to find and filter processes in the java tests. This permission is not needed when running theStatusTool
through the CLI, as the Security Manager is not interfering there.The error returned in test messages mentions:
IMPORTANT: This PR edits the test security policies and grants the execute permission to all files.
Tests
The PR fixes an issue in the
PATH
filtering logic for determining the classpath on Windows. Since on Windows an escaped backslash (\\
) is used, path segments are checked individually instead.Changes should be backported to
branch_9x
.Checklist
Please review the following and check all that apply:
main
branch../gradlew check
.