Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOLR-17352: CLI - Remove unsupported options for auth command #2858

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

malliaridis
Copy link
Contributor

https://issues.apache.org/jira/browse/SOLR-17352

Description

The auth command is currently using -s for setting solr-home (bin\solr.cmd) and for solr-url (AuthTool). This overlapping prevents the user from using the -s option for solr-url.

Solution

Remove overlapping and deprecated option variants (-s and -d) from bin/solr.cmd to allow -s being used for solr-url.

Changes should be backported to branch_9x (not sure if branch_9_7 should also include these changes).

Tests

Tested manually only due to the lack of windows tests. See SOLR-17508.

Checklist

Please review the following and check all that apply:

  • I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
  • I have created a Jira issue and added the issue ID to my pull request title.
  • I have given Solr maintainers access to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation)
  • I have developed this patch against the main branch.
  • I have run ./gradlew check.
  • I have added tests for my changes.
  • I have added documentation for the Reference Guide

Copy link
Contributor

@epugh epugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! I really like how the long format commands look when I read the code, it just is so much more readable. Especially when I haven't been living in the script for a week or so and my memory of the short versions of the commands immediately gets fuzzy!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants