Skip to content

Commit

Permalink
[SPARK-44583][DOC] spark.*.io.connectionCreationTimeout parameter d…
Browse files Browse the repository at this point in the history
…ocumentation

### What changes were proposed in this pull request?

### Why are the changes needed?
`spark.*.io.connectionCreationTimeout` The parameter description is missing, and the default time of the comment is wrong.

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?

Closes #42205 from cxzl25/SPARK-44583.

Authored-by: sychen <[email protected]>
Signed-off-by: Kent Yao <[email protected]>
  • Loading branch information
cxzl25 authored and yaooqinn committed Aug 1, 2023
1 parent c858851 commit 772ebd3
Show file tree
Hide file tree
Showing 2 changed files with 25 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ public int connectionTimeoutMs() {
return defaultTimeoutMs < 0 ? 0 : (int) defaultTimeoutMs;
}

/** Connect creation timeout in milliseconds. Default 30 secs. */
/** Connect creation timeout in milliseconds. Default 120 secs. */
public int connectionCreationTimeoutMs() {
long connectionTimeoutS = TimeUnit.MILLISECONDS.toSeconds(connectionTimeoutMs());
long defaultTimeoutMs = JavaUtils.timeStringAsSec(
Expand Down
24 changes: 24 additions & 0 deletions docs/configuration.md
Original file line number Diff line number Diff line change
Expand Up @@ -1041,6 +1041,14 @@ Apart from these, the following properties are also available, and may be useful
</td>
<td>1.2.0</td>
</tr>
<tr>
<td><code>spark.shuffle.io.connectionCreationTimeout</code></td>
<td>value of <code>spark.shuffle.io.connectionTimeout</code></td>
<td>
Timeout for establishing a connection between the shuffle servers and clients.
</td>
<td>3.2.0</td>
</tr>
<tr>
<td><code>spark.shuffle.service.enabled</code></td>
<td>false</td>
Expand Down Expand Up @@ -1217,6 +1225,14 @@ Apart from these, the following properties are also available, and may be useful
</td>
<td>1.6.0</td>
</tr>
<tr>
<td><code>spark.files.io.connectionCreationTimeout</code></td>
<td>value of <code>spark.files.io.connectionTimeout</code></td>
<td>
Timeout for establishing a connection for fetching files in Spark RPC environments.
</td>
<td>3.2.0</td>
</tr>
<tr>
<td><code>spark.shuffle.checksum.enabled</code></td>
<td>true</td>
Expand Down Expand Up @@ -2442,6 +2458,14 @@ Apart from these, the following properties are also available, and may be useful
</td>
<td>1.2.0</td>
</tr>
<tr>
<td><code>spark.rpc.io.connectionCreationTimeout</code></td>
<td>value of <code>spark.rpc.io.connectionTimeout</code></td>
<td>
Timeout for establishing a connection between RPC peers.
</td>
<td>3.2.0</td>
</tr>
</table>

### Scheduling
Expand Down

0 comments on commit 772ebd3

Please sign in to comment.