[SPARK-49593][SS] Throw RocksDB exception to the caller on DB close if an error is seen #48068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anishshri-db
changed the title
|
cc - @siying , @HeartSaVioR - PTAL, thx ! |
|
https://github.com/anishshri-db/spark/actions/runs/10803458710/job/29973660998 All modules passed except Docker integration test, it's still running. This is unrelated to this change. |
|
Thanks! Merging to master. |
attilapiros
pushed a commit
to attilapiros/spark
that referenced
this pull request
Oct 4, 2024
…f an error is seen ### What changes were proposed in this pull request? Throw RocksDB exception to the caller on DB close API here: https://javadoc.io/doc/org.rocksdb/rocksdbjni/6.8.1/org/rocksdb/RocksDB.html#closeE() ### Why are the changes needed? Without this, errors on close are being silently ignored and we attempt to open the DB again in the context of the same task. Trying to ensure that we exit in this scenario and try as part of a separate attempt. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Existing unit tests ``` [info] Total number of tests run: 205 [info] Suites: completed 1, aborted 0 [info] Tests: succeeded 205, failed 0, canceled 0, ignored 0, pending 0 [info] All tests passed. ``` ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#48068 from anishshri-db/task/SPARK-49593. Authored-by: Anish Shrigondekar <[email protected]> Signed-off-by: Jungtaek Lim <[email protected]>
himadripal
pushed a commit
to himadripal/spark
that referenced
this pull request
Oct 19, 2024
…f an error is seen ### What changes were proposed in this pull request? Throw RocksDB exception to the caller on DB close API here: https://javadoc.io/doc/org.rocksdb/rocksdbjni/6.8.1/org/rocksdb/RocksDB.html#closeE() ### Why are the changes needed? Without this, errors on close are being silently ignored and we attempt to open the DB again in the context of the same task. Trying to ensure that we exit in this scenario and try as part of a separate attempt. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Existing unit tests ``` [info] Total number of tests run: 205 [info] Suites: completed 1, aborted 0 [info] Tests: succeeded 205, failed 0, canceled 0, ignored 0, pending 0 [info] All tests passed. ``` ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#48068 from anishshri-db/task/SPARK-49593. Authored-by: Anish Shrigondekar <[email protected]> Signed-off-by: Jungtaek Lim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Throw RocksDB exception to the caller on DB close
API here: https://javadoc.io/doc/org.rocksdb/rocksdbjni/6.8.1/org/rocksdb/RocksDB.html#closeE()
Why are the changes needed?
Without this, errors on close are being silently ignored and we attempt to open the DB again in the context of the same task. Trying to ensure that we exit in this scenario and try as part of a separate attempt.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing unit tests
Was this patch authored or co-authored using generative AI tooling?
No