Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-49685][CONNECT] Increase CONNECT_GRPC_MARSHALLER_RECURSION_LIMIT from 1024 to 2048 #48133

Draft
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

longvu-db
Copy link
Contributor

@longvu-db longvu-db commented Sep 17, 2024

What changes were proposed in this pull request?

Increase the CONNECT_GRPC_MARSHALLER_RECURSION_LIMIT that was introduced in this PR.

Why are the changes needed?

While developing a Spark Connect Plugin, I ran into this error

com.google.protobuf.InvalidProtocolBufferException: Protocol message had too many levels of nesting. May be malicious. Use CodedInputStream.setRecursionLimit() to increase the depth limit.

Increasing the above limit will solve the issue.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Existing UTs.

Was this patch authored or co-authored using generative AI tooling?

No.

@longvu-db longvu-db changed the title [SPARK-49685][CONNECT] Increase CONNECT_GRPC_MARSHALLER_RECURSION_LIMIT from 1024 to 4096 [SPARK-49685][CONNECT] Increase CONNECT_GRPC_MARSHALLER_RECURSION_LIMIT from 1024 to 2048 Sep 19, 2024
Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a test case for this, please, @longvu-db ?

Increasing the above limit will solve the issue.

@longvu-db
Copy link
Contributor Author

Hey @dongjoon-hyun, my PR wasn't ready for review yet as I was testing the limit of this configuration, setting a high limit will cause a java.lang.StackOverflowError this test, but thank you for your feedback.

@dongjoon-hyun dongjoon-hyun marked this pull request as draft September 19, 2024 20:23
@dongjoon-hyun
Copy link
Member

There are two community recommendations for that case, @longvu-db . Please choose one which you want to prefer.

  • You can use GitHub Draft feature.
  • You can use your fork to run the same testing before making to the PR.

Hey @dongjoon-hyun, my PR wasn't ready for review yet as I was testing the limit of this configuration, setting a high limit will cause a java.lang.StackOverflowError this test, but thank you for your feedback.

@dongjoon-hyun
Copy link
Member

For this one, I converted this to Draft for you because the PR was already created.

@longvu-db
Copy link
Contributor Author

longvu-db commented Sep 19, 2024

I see, thank you very much for this kind tip @dongjoon-hyun!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants