-
Notifications
You must be signed in to change notification settings - Fork 28.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-49685][CONNECT] Increase CONNECT_GRPC_MARSHALLER_RECURSION_LIMIT from 1024 to 2048 #48133
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a test case for this, please, @longvu-db ?
Increasing the above limit will solve the issue.
Hey @dongjoon-hyun, my PR wasn't ready for review yet as I was testing the limit of this configuration, setting a high limit will cause a |
There are two community recommendations for that case, @longvu-db . Please choose one which you want to prefer.
|
For this one, I converted this to |
I see, thank you very much for this kind tip @dongjoon-hyun! |
What changes were proposed in this pull request?
Increase the
CONNECT_GRPC_MARSHALLER_RECURSION_LIMIT
that was introduced in this PR.Why are the changes needed?
While developing a Spark Connect Plugin, I ran into this error
Increasing the above limit will solve the issue.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing UTs.
Was this patch authored or co-authored using generative AI tooling?
No.