-
Notifications
You must be signed in to change notification settings - Fork 28.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-49415][CONNECT][SQL] Move SQLImplicits to sql/api #48151
base: master
Are you sure you want to change the base?
Conversation
} | ||
|
||
/** @since 1.6.1 */ | ||
implicit def newIntArrayEncoder: Encoder[Array[Int]] = newArrayEncoder(PrimitiveIntEncoder) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These should be vals
implicit def newPeriodEncoder: Encoder[java.time.Period] = Encoders.PERIOD | ||
|
||
/** @since 3.2.0 */ | ||
implicit def newJavaEnumEncoder[A <: java.lang.Enum[_]: TypeTag]: Encoder[A] = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be faster. There is no need to use ScalaReflection here.
/** @since 1.6.0 */ | ||
implicit def newProductEncoder[T <: Product : TypeTag]: Encoder[T] = Encoders.product[T] | ||
|
||
implicit def rddToDatasetHolder[T : Encoder](rdd: RDD[T]): DatasetHolder[T, Dataset] = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will move this as soon as the shims land.
What changes were proposed in this pull request?
This PR largely moves SQLImplicits and DatasetHolder to sql/api.
Why are the changes needed?
We are creating a unified Scala interface for Classic and Connect.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing tests.
Was this patch authored or co-authored using generative AI tooling?
No.