[MINOR] Abort changelog writer before resetting #48153
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tedyu
changed the title
|
@HeartSaVioR |
HyukjinKwon
changed the title
HyukjinKwon
reviewed
Sep 18, 2024
| changelogWriter.foreach(_.abort()) | ||
| } finally { | ||
| changelogWriter = None | ||
| } |
There was a problem hiding this comment.
Seems like #48148 includes this fix
There was a problem hiding this comment.
I came up with this PR around the same time as #48148.
Since the fix is independent of the above PR, do you think this can go in first ?
Thanks
There was a problem hiding this comment.
@tedyu - Actually we can't do the abort at all here. we need to ensure that the changelog file is written out. Otherwise it breaks reading the state in change-data-feed mode. Pls take a look at my fix - thx !
There was a problem hiding this comment.
we can maybe just fix the update on the error message tho as part of this PR. Will let @HeartSaVioR decide
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In
commit(),changelogWriteris set toNonebefore iterating.This PR calls
abort()on thechangelogWriterbefore resetting.This is consistent with what
rollbackdoes.Why are the changes needed?
To properly handle the abort of
changelogWriter.Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing test suite.
Was this patch authored or co-authored using generative AI tooling?
No