[SPARK-49723][SQL] Add Variant metrics to the JSON File Scan node #48172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
reviewed
Sep 19, 2024
common/variant/src/main/java/org/apache/spark/types/variant/VariantBuilder.java
Outdated
Show resolved
Hide resolved
cloud-fan
reviewed
Sep 20, 2024
|
|
||
| /** Only report variant metrics if the data source file format is JSON */ | ||
| override lazy val metrics: Map[String, SQLMetric] = super.metrics ++ { | ||
| if (relation.fileFormat.isInstanceOf[JsonFileFormat]) variantBuilderMetrics |
There was a problem hiding this comment.
does json scan always produce variants? If not we should only display these metrics when variant will be produced by the scan.
cloud-fan
reviewed
Sep 20, 2024
| val readFile: (PartitionedFile) => Iterator[InternalRow] = { | ||
| val hadoopConf = relation.sparkSession.sessionState.newHadoopConfWithOptions(relation.options) | ||
| relation.fileFormat match { | ||
| case f: JsonFileFormat => |
There was a problem hiding this comment.
We should probably make it more general and allow FileFormat implementations to report additional metrics.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This pull request adds the following metrics to JSON file scan nodes to collect metrics related to variants being constructed as part of the scan:
Top level and nested variant metrics are separated as they can have different usage patterns.
singleVariantColumnscans and columns in user-provided schema scans where the column type is a top level variant (not variant nested in a struct/array/map) are considered to be top level variants while variants nested in other data types are considered to be nested variants.Why are the changes needed?
This change allows users to collect metrics on variant usage to better monitor their data/workloads.
Does this PR introduce any user-facing change?
Users will now be able to see variant metrics in JSON scan nodes which were not available earlier.
How was this patch tested?
Comprehensive unit tests in VariantEndToEndSuite.scala
Was this patch authored or co-authored using generative AI tooling?
Yes, got some help related to scala syntax.
Generated by: ChatGPT 4o, GitHub CoPilot.