[SPARK-49722][CONNECT] Fix Column ordering of dropDuplicates and dropDuplicatesWithinWatermarks #48173
+27
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeartSaVioR
reviewed
Sep 19, 2024
...connect/server/src/main/scala/org/apache/spark/sql/connect/planner/SparkConnectPlanner.scala
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Similar to SPARK-31990, We must keep
toSet.toSeqhere because of the backward compatibility issue (the Streaming's state store depends on thegroupColsorder). Without this patch, a stateful streaming query cannot be rerun under spark connect if it was previous ran under vanilla spark (and vice versa)Why are the changes needed?
Bug fix
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing CI should pass, functional wise this is straightforward
Was this patch authored or co-authored using generative AI tooling?
No