Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Minor] Catch exception from snapshot uploading #48185

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -644,8 +644,14 @@ class RocksDB(
// If we have changed the columnFamilyId mapping, we have set a new
// snapshot and need to upload this to the DFS even if changelog checkpointing
// is enabled.
var ex: Throwable = null
if (shouldForceSnapshot.get()) {
uploadSnapshot()
try {
uploadSnapshot()
} catch {
case t: Throwable =>
ex = t
}
shouldForceSnapshot.set(false)
}

Expand All @@ -656,6 +662,7 @@ class RocksDB(
} finally {
changelogWriter = None
}
if (ex != null) throw ex;
} else {
assert(changelogWriter.isEmpty)
uploadSnapshot()
Expand Down