[SPARK-49877][SQL] Change classifyException function signature: add isRuntime argument #48351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o syntaxErrorsJdbc
…o syntaxErrorsJdbc
MaxGekk
requested changes
Oct 4, 2024
sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala
Outdated
Show resolved
Hide resolved
| messageParameters: Map[String, String], | ||
| description: String): AnalysisException = { | ||
| new AnalysisException( | ||
| errorClass = "...", |
There was a problem hiding this comment.
You should assign proper error condition (class) here.
There was a problem hiding this comment.
but we're removing it?
sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala
Outdated
Show resolved
Hide resolved
MaxGekk
reviewed
Oct 4, 2024
| */ | ||
| def classifyException( | ||
| e: Throwable, | ||
| errorClass: String, | ||
| messageParameters: Map[String, String], | ||
| description: String): AnalysisException = { | ||
| description: String, | ||
| isRuntime: Boolean): Throwable with SparkThrowable = { |
There was a problem hiding this comment.
Sorry for back and forth, but do we need this flag now?
There was a problem hiding this comment.
We will need it for this pr: #48182(after this is merged I will do some modifications).
|
The tests are now passing. Could you make a review @MaxGekk? Thanks. |
MaxGekk
reviewed
Oct 7, 2024
sql/core/src/main/scala/org/apache/spark/sql/jdbc/DB2Dialect.scala
Outdated
Show resolved
Hide resolved
MaxGekk
approved these changes
Oct 7, 2024
MaxGekk
reviewed
Oct 7, 2024
| @@ -741,13 +741,15 @@ abstract class JdbcDialect extends Serializable with Logging { | |||
| * @param errorClass The error class assigned in the case of an unclassified `e` | |||
| * @param messageParameters The message parameters of `errorClass` | |||
| * @param description The error description | |||
| * @return `AnalysisException` or its sub-class. | |||
| * @param isRuntime Whether the exception is a runtime exception or not. | |||
| * @return `SparkThrowable + Throwable` or its sub-class. | |||
| */ | |||
| def classifyException( | |||
There was a problem hiding this comment.
This method has not been released yet, so, we can modify it.
|
+1, LGTM. Merging to master. |
himadripal
pushed a commit
to himadripal/spark
that referenced
this pull request
Oct 19, 2024
…sRuntime argument ### What changes were proposed in this pull request? The proposal is to update the classifyException function so that it can return either ```AnalysisException``` or ```SparkRuntimeException```. This is achieved by adding a new parameter, ```isRuntime```, and modifying the return type to be ```Throwable with SparkThrowable``` for compatibility with both types. ### Why are the changes needed? The changes are needed to allow the classifyException function to be used in execution part of the code. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Not needed. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#48351 from ivanjevtic-db/Change-classify-exception-function-signature. Lead-authored-by: ivanjevtic-db <[email protected]> Co-authored-by: Ivan Jevtic <[email protected]> Co-authored-by: milastdbx <[email protected]> Co-authored-by: Maxim Gekk <[email protected]> Signed-off-by: Max Gekk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The proposal is to update the classifyException function so that it can return either
AnalysisExceptionorSparkRuntimeException. This is achieved by adding a new parameter,isRuntime, and modifying the return type to beThrowable with SparkThrowablefor compatibility with both types.Why are the changes needed?
The changes are needed to allow the classifyException function to be used in execution part of the code.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Not needed.
Was this patch authored or co-authored using generative AI tooling?
No.