[SPARK-50880][SQL] Add a new visitBinaryComparison method to V2ExpressionSQLBuilder #49556
+19
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to add a new
visitBinaryComparisonmethod toV2ExpressionSQLBuilder.Why are the changes needed?
The origin
visitBinaryComparisonmethod is not good for users when the compare predicate is related to the data type.Such as: Oracle doesn't support predicate '=' for binary and need use
DBMS_LOB.COMPAREto replace.So the old
visitBinaryComparisonmethod is not flexible and introduce some hacker code.Does this PR introduce any user-facing change?
'No'.
Just add a new API.
How was this patch tested?
GA.
Was this patch authored or co-authored using generative AI tooling?
'No'.