[SPARK-51264][SQL][JDBC] JDBC write keeps driver connection open unnecessarily #50014
+7
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Close connection before
saveTablecalls inorg.apache.spark.sql.execution.datasources.jdbc.JdbcRelationProvider. Check if the connection has been already closed before the lastclosein thefinallyblock.Why are the changes needed?
A JDBC connection was created in the
JdbcRelationProviderclass to truncate, drop, or create the table. However, this connection remained open and idle throughout the entire save process, which could take some time. This caused unnecessary resource consumption on both the Spark driver and the database. Additionally, the idle connection was at risk of being dropped by the database, firewall, or proxy. Best practices recommend releasing resources as soon as they are no longer needed.Does this PR introduce any user-facing change?
No
How was this patch tested?
Local tests + Spark unit tests
Was this patch authored or co-authored using generative AI tooling?
No