[SPARK-51268][SQL] Make TreeNode lock-free
#50019
Draft
+17
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @JoshRosen and @cloud-fan |
zhengruifeng
commented
Feb 21, 2025
| @@ -67,15 +67,16 @@ abstract class QueryPlan[PlanType <: QueryPlan[PlanType]] | |||
| def outputOrdering: Seq[SortOrder] = Nil | |||
|
|
|||
| // Override `treePatternBits` to propagate bits for its expressions. | |||
| override lazy val treePatternBits: BitSet = { | |||
| private val _treePatternBits = new BestEffortLazyVal[BitSet](() => { | |||
There was a problem hiding this comment.
treePatternBits was kept lazy val in previous PR, do you @cloud-fan remember it was intended or not?
There was a problem hiding this comment.
Curiously, Since the treePatternBits only init once, how it keep the correctness if the expressions transformed with rules?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Make
TreeNodelock-free, by replacelazy valwithBestEffortLazyValWhy are the changes needed?
In several deadlock issues, we observed that the lock of
TreeNode._hashCodeis the root cause.Does this PR introduce any user-facing change?
no
How was this patch tested?
ci
Was this patch authored or co-authored using generative AI tooling?
no