-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-51338][INFRA] Add automated CI build for connect-examples
#50187
base: master
Are you sure you want to change the base?
Conversation
@HyukjinKwon can you take a look? |
@@ -92,6 +92,7 @@ jobs: | |||
pyspark_pandas_modules=`cd dev && python -c "import sparktestsupport.modules as m; print(','.join(m.name for m in m.all_modules if m.name.startswith('pyspark-pandas')))"` | |||
pyspark=`./dev/is-changed.py -m $pyspark_modules` | |||
pandas=`./dev/is-changed.py -m $pyspark_pandas_modules` | |||
connect_examples=`./dev/is-changed.py -m "connect-examples"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we want to run this with Java 21 (and other scheduled builds), we would need to add this in https://github.com/apache/spark/blob/master/.github/workflows/build_java21.yml too as an example, .e.g., "connect_examples": "true"
- name: Build server-library-example | ||
run: | | ||
cd connect-examples/server-library-example | ||
mvn clean package |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use build/sbt
instead? We use SBT in the PR builder
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good otherwise
connect-examples
connect-examples
I've noticed a rather peculiar issue here. It seems that the For example, when Spark 4.0.0 is released, the version of this project in the published v4.0.0 tag won't be Spark 4.0.0, but rather some previously released version. Am I right about this? If I'm wrong, please correct me. If I'm right, doesn't that seem a bit strange? Therefore, I still believe that spark/connect-examples/server-library-example/pom.xml Lines 19 to 42 in f40bf4d
What do you think about this? @HyukjinKwon @hvanhovell @dongjoon-hyun @cloud-fan @srowen @yaooqinn |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should discuss #50187 (comment) clearly before merging
Can the examples module simply point to SNAPSHOT versions like everything else in the build? the main branch code is always pointing at unreleased code, but on release, those SNAPSHOT versions are changed to the current release version. |
Yes, if it can be done this way, I think it's ok. |
What changes were proposed in this pull request?
Adds a build step for the
connect-examples
directory (specifically theserver-library-example
project) in the CI steps (build_and_test.yml
)Why are the changes needed?
No existing automated CI build atm
Does this PR introduce any user-facing change?
No
How was this patch tested?
CI run in this PR
Was this patch authored or co-authored using generative AI tooling?
Generated-by: o3-mini-high