[WIP][SPARK-51428][SQL] Reassign Aliases for collated expression trees deterministically #50192
+83
−53
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Reassign Aliases for collated expression trees deterministically at the end of Analysis.
Why are the changes needed?
Consider the following collated queries and their schemas:
1.
The 1. case has an explicit alias where 'A' literal is marked as collated, which is correct. However, in the second case, 'a' literal is not marked as collated in the output implicit alias, despite the fact that it is indeed collated by
CollationTypeCoercion
. The 2. output schema has to beconcat_ws('a' collate UTF8_LCASE, col1, col1)
.This happens because in 1. case
ResolveAliases
runs after theAnsiCombinedTypeCoercionRule
, and in 2. case the order is the opposite, so alias is assigned before the actual data type is collated.ResolveAliases
relies on the aliased expression subtree being resolved. In the context of type coercion it'scheckInputDataTypes
. But this predicate doesn't really know about collations. Ideally we would fix all thecheckInputDataTypes
, but that would be quite involved.Does this PR introduce any user-facing change?
Yes, implicit aliases of collated expression trees now change. This is a breaking change.
How was this patch tested?
Golden files were regenerated
Was this patch authored or co-authored using generative AI tooling?
No.