[SPARK-51438][SQL] Make CatalystDataToProtobuf and ProtobufDataToCatalyst properly comparable and hashable #50212
+235
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladimirg-db
force-pushed
the
vladimir-golubev_data/fix-comparison-or-protobuf-expressions
branch
from
23021f6 to
ddc1396
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Hand-roll
equalsandhashCodeforCatalystDataToProtobufandProtobufDataToCatalyst.Why are the changes needed?
CatalystDataToProtobufandProtobufDataToCatalysthaveArray[Byte]in their case class fields, which makes them incomparable using the default-generated equals, becauseArray.equalsperforms reference comparison. We need to useArray.sameElements.Does this PR introduce any user-facing change?
No.
How was this patch tested?
New tests in
ProtobufCatalystDataConversionSuite.Was this patch authored or co-authored using generative AI tooling?
copilot.nvim