[SPARK-45994][PYTHON][3.5] Change description-file to description_file
#50371
Conversation
|
@srowen is this wright? and then we need 3.4 and ? do we need 3.3 to? |
|
Yes; I think it wouldn't hurt to back-port to 3.4 too, as it's a trivial change and there might be another 3.4 release. 3.3 is EOL though. |
|
@srowen Ok, I will wait til this have passed the tests and then in 2 to 3 hours I will make a new one for 3.4 branch. |
|
Thank you both for the quick work on this. I know it's affecting a lot of users, and we appreciate your efforts here. |
|
As expected, this affects a lot of stuff, so may be reverted in setuptools: pypa/setuptools#4911 |
bjornjorgensen
changed the title
description-file to description_filedescription-file to description_file
|
4) Spark 3.4.4: Released on October 27, 2024. This will be the final maintenance release for the 3.4 series. from Matei's ASF board report draft for November 2024 I have restarted the spark connect test |
There was a problem hiding this comment.
LGTM2. Let me know which one you like to merge @bjornjorgensen
|
Thank you @HyukjinKwon this is the same as we did for branch 4 #43891 As a open source project we always need new contributes, so I hope we can fix and merge @abravalheri PR #50369 |
|
I think this has to be better addressed soon. I will merge this one instead if that's the case |
|
Merged to branch-3.5. Thank you @bjornjorgensen and others as well! |
…file`
### What changes were proposed in this pull request?
Change `description-file` to `description_file`
### Why are the changes needed?
`./dev/make-distribution.sh --name custom-spark --pip -Pkubernetes > output.txt 2>&1`
in the file there is this
```
+ echo 'Building python distribution package'
Building python distribution package
+ pushd /home/bjorn/spark/python
+ rm -rf pyspark.egg-info
+ python3 setup.py sdist
/usr/lib/python3.11/site-packages/setuptools/dist.py:745: SetuptoolsDeprecationWarning: Invalid dash-separated options
!!
********************************************************************************
Usage of dash-separated 'description-file' will not be supported in future
versions. Please use the underscore name 'description_file' instead.
This deprecation is overdue, please update your project and remove deprecated
calls to avoid build errors in the future.
See https://setuptools.pypa.io/en/latest/userguide/declarative_config.html for details.
********************************************************************************
!!
opt = self.warn_dash_deprecation(opt, section)
running sdist
running egg_info
```
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Pass GA
### Was this patch authored or co-authored using generative AI tooling?
No.
Closes #50369
Closes #50372
Closes #50371 from bjornjorgensen/bjornjorgensen-description_file3.5].
Authored-by: Bjørn Jørgensen <[email protected]>
Signed-off-by: Hyukjin Kwon <[email protected]>
What changes were proposed in this pull request?
Change
description-filetodescription_fileWhy are the changes needed?
./dev/make-distribution.sh --name custom-spark --pip -Pkubernetes > output.txt 2>&1in the file there is this
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass GA
Was this patch authored or co-authored using generative AI tooling?
No.
Closes #50369
Closes #50372