[SPARK-51657] UTF8_BINARY default table collation shown by default in Desc As JSON (v1) #50451
+36
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gengliangwang
approved these changes
Mar 28, 2025
|
FYI there is test failure |
|
thanks, merging to master |
gengliangwang
pushed a commit
that referenced
this pull request
Apr 1, 2025
… Desc As JSON (v1) ### What changes were proposed in this pull request? Display `UTF8_BINARY` default table collation by default in Desc As JSON for v1 table. Note this only affects the `desc as json` output and not `desc table extended` -- desc table does NOT always show the top-level table collation (if omitted in the`desc table` output, it is `UTF8_BINARY`) ### Why are the changes needed? If the CatalogTable `collation` property is None, then it is by default `UTF8_BINARY`. This update is for completeness for the `desc as json` output. ### Does this PR introduce _any_ user-facing change? Yes, affects the JSON result ### How was this patch tested? Added tests in `v1/DescribeTableSuite.scala` ### Was this patch authored or co-authored using generative AI tooling? No Closes #50451 from asl3/asl3/descasjson-defaultcollation. Authored-by: Amanda Liu <[email protected]> Signed-off-by: Gengliang Wang <[email protected]> (cherry picked from commit 13945c8) Signed-off-by: Gengliang Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Display
UTF8_BINARYdefault table collation by default in Desc As JSON for v1 table.Note this only affects the
desc as jsonoutput and notdesc table extended-- desc table does NOT always show the top-level table collation (if omitted in thedesc tableoutput, it isUTF8_BINARY)Why are the changes needed?
If the CatalogTable
collationproperty is None, then it is by defaultUTF8_BINARY. This update is for completeness for thedesc as jsonoutput.Does this PR introduce any user-facing change?
Yes, affects the JSON result
How was this patch tested?
Added tests in
v1/DescribeTableSuite.scalaWas this patch authored or co-authored using generative AI tooling?
No