[SPARK-52046] [SQL] Prettify OuterReference on AggregateExpression names when using toPrettySQL #50836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihailoale-db
changed the title
mihailoale-db
force-pushed
the
prettifyouterrefname
branch
from
5aca4ce to
c29527b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In this PR I propose that we remove backticks, qualifiers from
OuterReferenceoverAggregateExpressionwhen creating name. In other words, name forcolumnwhich is an outer reference would beouter(min(column))instead ofouter('min(col)').Why are the changes needed?
To ease development of single-pass analyzer and improve names in fixed-point implementation.
Does this PR introduce any user-facing change?
Schema changes in a way that
OuterReferenceoverAggregateExpressionname doesn't contain backticks and qualifiers.How was this patch tested?
Existing tests.
Was this patch authored or co-authored using generative AI tooling?
No.