[SPARK-52866][SQL] Add support for try_to_date
#51555
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihailom-db
changed the title
try_to_datetry_to_date
MaxGekk
reviewed
Jul 18, 2025
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
Outdated
Show resolved
Hide resolved
cloud-fan
reviewed
Jul 18, 2025
cloud-fan
approved these changes
Jul 18, 2025
MaxGekk
approved these changes
Jul 18, 2025
MaxGekk
reviewed
Jul 22, 2025
| @@ -2125,7 +2125,7 @@ case class ParseToDate( | |||
| this(left, None) | |||
| } | |||
|
|
|||
| override def prettyName: String = "to_date" | |||
| override def nodeName: String = "to_date" | |||
There was a problem hiding this comment.
What's the reason for the replacement?
|
+1, LGTM. Merging to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR adds alias for calling
try_to_date, this function behaves the same asto_date, but returns NULL on errors.Why are the changes needed?
As part of #49227 we have changed the error message for ToTimestamp when we call the function
to_dateto returntry_to_datesuggestion. This suggestion is not available and this PR fixes the issue.Does this PR introduce any user-facing change?
Yes, we are adding new function call.
How was this patch tested?
Tests added in docs.
Was this patch authored or co-authored using generative AI tooling?
No.