[SPARK-52905][PYTHON][FOLLOW-UP] ArrowWindowPythonExec code clean up #51648
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
approved these changes
Jul 24, 2025
zhengruifeng
force-pushed
the
arrow_udf_win_followup
branch
from
bd8ce24 to
fca59f7
Compare
viirya
approved these changes
Jul 24, 2025
viirya
reviewed
Jul 24, 2025
| @@ -61,7 +61,7 @@ import org.apache.spark.sql.execution.window._ | |||
| * Unbounded window takes only input columns. | |||
| * (2) Bounded window evaluates the udf once per input row. | |||
| * Unbounded window evaluates the udf once per window partition. | |||
| * This is controlled by Python runner conf "pandas_window_bound_types" | |||
| * This is controlled by Python runner conf "window_bound_types" | |||
There was a problem hiding this comment.
This may be updated in migration guide.
There was a problem hiding this comment.
it seems this configuration udfWindowBoundTypes is not a user-facing one:
private val pythonRunnerConf: Map[String, String] =
(ArrowPythonRunner.getPythonRunnerConfMap(conf)
+ (windowBoundTypeConf -> udfWindowBoundTypes.map(_.value).mkString(",")))
It was used to pass a extra value to the python side.
xinrong-meng
approved these changes
Jul 24, 2025
|
LGTM thank you |
|
thank you all, merged to master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Accept non-udaf window expression in ArrowWindowPythonExec
Why are the changes needed?
proper error message
Does this PR introduce any user-facing change?
no
How was this patch tested?
ci
Was this patch authored or co-authored using generative AI tooling?
no