Skip to content

[SPARK-53215][CORE][TESTS] Use JavaUtils.listFiles in CleanupNonShuffleServiceServedFilesSuite #51940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Aug 8, 2025

What changes were proposed in this pull request?

This PR aims to use JavaUtils.listFiles instead of private static Set<String> collectFilenames in CleanupNonShuffleServiceServedFilesSuite.

Why are the changes needed?

To remove the duplication for the similar functionality.

Does this PR introduce any user-facing change?

No, this is a test-only change.

How was this patch tested?

Pass the CIs.

Was this patch authored or co-authored using generative AI tooling?

No.

@github-actions github-actions bot added the CORE label Aug 8, 2025
@dongjoon-hyun
Copy link
Member Author

All tests passed.

@dongjoon-hyun
Copy link
Member Author

Could you review this removal PR when you have some time, @peter-toth ?

Copy link
Contributor

@peter-toth peter-toth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dongjoon-hyun
Copy link
Member Author

Oh, thank you so much, @peter-toth !

@dongjoon-hyun dongjoon-hyun deleted the SPARK-53215 branch August 10, 2025 06:46
@dongjoon-hyun
Copy link
Member Author

Merged to master for Apache Spark 4.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants