Skip to content

[WIP][SPARK-52348][SDP] Trait for PipelinesHandler #52228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
+19 −11
Closed

[WIP][SPARK-52348][SDP] Trait for PipelinesHandler #52228

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 17 additions & 9 deletions ...nnect/server/src/main/scala/org/apache/spark/sql/connect/pipelines/PipelinesHandler.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,8 @@ import org.apache.spark.sql.pipelines.graph.{AllTables, FlowAnalysis, GraphIdent
import org.apache.spark.sql.pipelines.logging.{PipelineEvent, RunProgress}
import org.apache.spark.sql.types.StructType

/** Handler for SparkConnect PipelineCommands */
private[connect] object PipelinesHandler extends Logging {
/** Trait for handling SparkConnect PipelineCommands */
trait PipelinesHandler extends Logging {

/**
* Handles the pipeline command
Expand All @@ -47,14 +47,27 @@ private[connect] object PipelinesHandler extends Logging {
* Command to be handled
* @param responseObserver
* The response observer where the response will be sent
* @param sparkSession
* The spark session
* @param transformRelationFunc
* Function used to convert a relation to a LogicalPlan. This is used when determining the
* LogicalPlan that a flow returns.
* @return
* The response after handling the command
*/
def handlePipelinesCommand(
sessionHolder: SessionHolder,
cmd: proto.PipelineCommand,
responseObserver: StreamObserver[ExecutePlanResponse],
transformRelationFunc: Relation => LogicalPlan): PipelineCommandResult

/**
* A case class to hold the table filters for full refresh and refresh operations.
*/
protected case class TableFilters(fullRefresh: TableFilter, refresh: TableFilter)
}

/** Handler for SparkConnect PipelineCommands */
private[connect] object SparkPipelinesHandler extends PipelinesHandler {

def handlePipelinesCommand(
sessionHolder: SessionHolder,
cmd: proto.PipelineCommand,
Expand Down Expand Up @@ -358,9 +371,4 @@ private[connect] object PipelinesHandler extends Logging {
refresh = SomeTables(refreshTableNames))
}
}

/**
* A case class to hold the table filters for full refresh and refresh operations.
*/
private case class TableFilters(fullRefresh: TableFilter, refresh: TableFilter)
}
4 changes: 2 additions & 2 deletions ...nect/server/src/main/scala/org/apache/spark/sql/connect/planner/SparkConnectPlanner.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ import org.apache.spark.sql.connect.client.arrow.ArrowSerializer
import org.apache.spark.sql.connect.common.{DataTypeProtoConverter, ForeachWriterPacket, LiteralValueProtoConverter, StorageLevelProtoConverter, StreamingListenerPacket, UdfPacket}
import org.apache.spark.sql.connect.config.Connect.CONNECT_GRPC_ARROW_MAX_BATCH_SIZE
import org.apache.spark.sql.connect.ml.MLHandler
import org.apache.spark.sql.connect.pipelines.PipelinesHandler
import org.apache.spark.sql.connect.pipelines.SparkPipelinesHandler
import org.apache.spark.sql.connect.plugin.SparkConnectPluginRegistry
import org.apache.spark.sql.connect.service.{ExecuteHolder, SessionHolder, SparkConnectService}
import org.apache.spark.sql.connect.utils.MetricGenerator
Expand Down Expand Up @@ -2739,7 +2739,7 @@ class SparkConnectPlanner(
private def handlePipelineCommand(
command: proto.PipelineCommand,
responseObserver: StreamObserver[proto.ExecutePlanResponse]): Unit = {
val res = PipelinesHandler.handlePipelinesCommand(
val res = SparkPipelinesHandler.handlePipelinesCommand(
sessionHolder,
command,
responseObserver,
Expand Down