Add option to skip Unix native rm explicitly #52489
Open
+11
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
spark.skipUnixNativeRm
, to explicitly skip trying the Unix rm binaryshouldTryUnixNativeRm
Why are the changes needed?
In some Unix setups such as when using minimal containers, the
rm
binary is not available. Receiving an error message every time a call todeleteRecursively()
is made is confusing and noisy, even with the presence of the warning message. Making calls to an nonexistent binary also has a slight performance impact.As an application maintainer, I would like to be able to avoid this situation when I know my setup will never have the
rm
Unix binary.Does this PR introduce any user-facing change?
spark.skipUnixNativeRm
property,deleteRecursivelyUsingUnixNative
indeleteRecursively
is never called.How was this patch tested?
No unit tests exist for this specific class, and change is minor enough that I do not consider it worth the risk to add unit tests to the file, especially given my limited knowledge of Spark and the intended behaviour of that file, including potentially unexpected side-effects.
Was this patch authored or co-authored using generative AI tooling?
No