[SPARK-53760][Geo][SQL] Introduce GeometryType and GeographyType #52491
+1,143
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szehon-ho
reviewed
Oct 1, 2025
sql/api/src/main/scala/org/apache/spark/sql/catalyst/parser/DataTypeAstBuilder.scala
Outdated
Show resolved
Hide resolved
sql/api/src/main/scala/org/apache/spark/sql/types/CrsMappings.java
Outdated
Show resolved
Hide resolved
sql/api/src/main/scala/org/apache/spark/sql/types/DataType.scala
Outdated
Show resolved
Hide resolved
sql/api/src/main/scala/org/apache/spark/sql/types/GeographyType.scala
Outdated
Show resolved
Hide resolved
sql/api/src/main/scala/org/apache/spark/sql/types/GeometryType.scala
Outdated
Show resolved
Hide resolved
sql/api/src/main/scala/org/apache/spark/sql/types/GeographyType.scala
Outdated
Show resolved
Hide resolved
sql/api/src/main/scala/org/apache/spark/sql/types/GeometryType.scala
Outdated
Show resolved
Hide resolved
szehon-ho
reviewed
Oct 1, 2025
|
Hi folks, please re-review. @szehon-ho @mkaravel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Introduce two new logical types to Spark:
GeographyTypeGeometryTypeThis PR also adds appropriate SQL parsing and JSON serialization logic for the new types.
Why are the changes needed?
Kicking off https://issues.apache.org/jira/browse/SPARK-51658 by adding GEOMETRY and GEOGRAPHY types to Spark.
Does this PR introduce any user-facing change?
Yes, two new logical data types are added as
Experimental.How was this patch tested?
Added new tests to:
GeographyTypeSuiteGeometryTypeSuiteAlso, added appropriate test cases to:
DataTypeSuiteWas this patch authored or co-authored using generative AI tooling?
No.