[SPARK-53794][SS] Add option to limit deletions per maintenance operation associated with rocksdb state provider #52511
+89
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… associated with rocksdb state provider
anishshri-db
changed the title
|
cc - @HeartSaVioR - PTAL, thx ! |
ericm-db
reviewed
Oct 3, 2025
ericm-db
approved these changes
Oct 3, 2025
liviazhu
reviewed
Oct 4, 2025
| getStringConf(COMPRESSION_CONF), | ||
| storeConf.reportSnapshotUploadLag) | ||
| storeConf.reportSnapshotUploadLag, | ||
| storeConf.maxVersionsToDelete) |
There was a problem hiding this comment.
Can we check that minVersionToDelete <= maxVersionsToDelete and add a test?
| .map(_._1) | ||
| .filter(_ <= maxSnapshotVersionPresent - numVersionsToRetain + 1) | ||
| .filter( v => | ||
| if (maxVersionsToDelete != -1) { |
There was a problem hiding this comment.
nit: you can probably do (maxVersionsToDelete != -1) && (v <= minSnapshotVersionPresent + maxVersionsToDelete)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add option to limit deletions per maintenance operation associated with rocksdb state provider
Why are the changes needed?
We see some instances where the changelog deletion can take a really long time. This means that for that partition, we also cannot upload full snapshots which affects recovery/replay scenarios. This problem is much more apparent on resource constrained clusters. So, we add an option to allow for incremental cleanup per maintenance operation invocation.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Added unit tests
Was this patch authored or co-authored using generative AI tooling?
No