SPARK-53790 support generic beans in arrow encoder #52513
+53
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the past the arrow encoder used lookup.findVirtual to lookup getters and setters for java beans. `findVirtual` is however very sensitive for the exact type used. This type was extrated from the encoder. For generic beans it could however be erased and as such be a different type from the expected type. This patch will try the super classes of the expected type when the expected signature is not found.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the past the arrow encoder used lookup.findVirtual to lookup getters and setters for java beans.
findVirtualis however very sensitive for the exact type used. This type was extrated from the encoder. For generic beans it could however be erased and as such be a different type from the expected type.What changes were proposed in this pull request?
This patch will try the super classes of the expected type when the expected signature is not found.
Why are the changes needed?
More generic lookup of getter and setter method.
Does this PR introduce any user-facing change?
No, it fixes an exception.
How was this patch tested?
new unit test was adding testing the scenario.
Was this patch authored or co-authored using generative AI tooling?
No