[SPARK-53796][SDP] Add extension field to a few pipeline protos to support forward compatibility
#52514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SCHJonathan
changed the title
extension field to pipeline protos to support forward compatibility
SCHJonathan
changed the title
extension field to pipeline protos to support forward compatibilityextension field to pipeline protos to support forward compatibility
sryza
reviewed
Oct 3, 2025
sql/connect/common/src/main/protobuf/spark/connect/pipelines.proto
Outdated
Show resolved
Hide resolved
sql/connect/common/src/main/protobuf/spark/connect/pipelines.proto
Outdated
Show resolved
Hide resolved
|
Hi @vicennial @hvanhovell, wondering whether yall wanna take a look at this PR. This PR is adding extension field to the DefineDataset and DefineFlow proto to support databricks only field |
SCHJonathan
changed the title
extension field to pipeline protos to support forward compatibilityextension field to a few pipeline protos to support forward compatibility
sryza
changed the title
extension field to a few pipeline protos to support forward compatibilityextension field to a few pipeline protos to support forward compatibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Adding
google.protobuf.Any extension = 999;field toPipelineCommandandSourceCodeLocationProtos to support forward-compatibility by carrying additional pipeline command types, source code location fields that are not yet defined in this version of the proto.During the planning stage, the Spark Server will resolve and dispatch command / message to the correct handler.
Why are the changes needed?
To support forward-compatibility by carrying additional pipeline command types / dataset or flow's fields that are not yet defined in this version of the proto. Useful for platforms that want to extend pipeline commands with platform-specific capabilities.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Test will be added for feature works using this new field
Was this patch authored or co-authored using generative AI tooling?
No