[SPARK-54026][BUILD] Use BOM for AWS Java SDK V2 dependency management #52728
+13
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pan3793
reviewed
Oct 27, 2025
| <dependency> | ||
| <groupId>software.amazon.awssdk</groupId> | ||
| <artifactId>bom</artifactId> | ||
| <version>${aws.java.sdk.v2.version}</version> |
There was a problem hiding this comment.
Since you have used BOM to manage versions, the explicit version definition at the sub-module's pom.xml is not required, right?
hadoop-cloud/pom.xml
resource-managers/kubernetes/integration-tests/pom.xml
pan3793
reviewed
Oct 27, 2025
| lazy val jacksonVersion = sys.props.get("fasterxml.jackson.version").getOrElse("2.20.0") | ||
| lazy val jacksonDeps = Bom.dependencies("com.fasterxml.jackson" % "jackson-bom" % jacksonVersion) | ||
| lazy val settings = jacksonDeps ++ Seq( | ||
| lazy val awsJavaSdkV2Version = sys.props.get("aws.java.sdk.v2.version").getOrElse("2.29.52") |
There was a problem hiding this comment.
the drawback is, we need to duplicate the version definition here again, would be better to investigate if we can extract the version from pom.xml directly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Use AWS Java SDK V2 BOM for consistent dependency management.
Why are the changes needed?
AWS Java SDK V2 expects consistent dependencies (https://docs.aws.amazon.com/sdk-for-java/latest/developer-guide/setup-project-maven.html)
Does this PR introduce any user-facing change?
No
How was this patch tested?
Checked Kinesis ASL works both with maven and SBT
Was this patch authored or co-authored using generative AI tooling?
No