Skip to content

[SPARK-54787][PS] Use list comprehension in pandas _bool_column_labels #53550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
devin-petersohn wants to merge 3 commits into from
+3 −9
Closed

[SPARK-54787][PS] Use list comprehension in pandas _bool_column_labels #53550

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4a0de07
[SPARK-54787][PS] Use list comprehension in pandas _bool_column_labels
devin-petersohn Dec 19, 2025
be0b28b
Reformat
devin-petersohn Dec 19, 2025
fd52a4c
Comment
devin-petersohn Dec 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions python/pyspark/pandas/frame.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11262,15 +11262,9 @@ def _bool_column_labels(self, column_labels: List[Label]) -> List[Label]:
"""
Filter column labels of boolean columns (without None).
"""
bool_column_labels = []
for label in column_labels:
psser = self._psser_for(label)
if is_bool_dtype(psser):
# Rely on dtype rather than spark type because
# columns that consist of bools and Nones should be excluded
# if bool_only is True
bool_column_labels.append(label)
return bool_column_labels
# Rely on dtype rather than spark type because columns that consist of bools and
# Nones should be excluded if bool_only is True
return [label for label in column_labels if is_bool_dtype(self._psser_for(label))]

def _result_aggregated(
self, column_labels: List[Label], scols: Sequence[PySparkColumn]
Expand Down