This repository has been archived by the owner on Jul 10, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 252
SUBMARINE-1261. Put configurations into Kubernetes Configmap #969
Open
raykuo18
wants to merge
13
commits into
apache:master
Choose a base branch
from
raykuo18:SUBMARINE-1261
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…construct configmap
@KUAN-HSUN-LI Please help me review the code |
// Debug
LOG.info("//////////////////// setupJettyServer Debug //////////////////");
LOG.info("SUBMARINE_SERVER_JETTY_THREAD_POOL_MAX: " +
Integer.toString(conf.getInt(SubmarineConfVars.ConfVars.SUBMARINE_SERVER_JETTY_THREAD_POOL_MAX))); If we explicitly use debug log in this part, I suggest changing the log level to debug/trace, for example: if (LOG.isDebugEnabled()) {
LOG.debug("xxxxx");
} |
jdbc.url: "jdbc:mysql://127.0.0.1:3306/submarine?useUnicode=true&characterEncoding=UTF-8&autoReconnect=true&allowMultiQueries=true&failOverReadOnly=false&zeroDateTimeBehavior=convertToNull&useSSL=false&serverTimezone=UTC&useTimezone=true&useLegacyDatetimeCode=true" If we choose to replace XML configuration based on ConfigMap, I suggest changing |
ConfVars(String varName, VarType type) {
switch(type) {
case STRING:
this.varName = varName;
this.varClass = String.class;
if (varName == "submarine.server.ssl.key.manager.password" ||
varName == "submarine.server.ssl.truststore.path" ||
varName == "submarine.server.ssl.truststore.type" ||
varName == "submarine.server.ssl.truststore.password"
) {
this.stringValue = null;
} else {
this.stringValue = System.getenv(varName);
}
this.intValue = -1;
this.floatValue = -1;
this.longValue = -1;
this.booleanValue = false;
break; I don't think it is a good way to remove the default value from the method parameters and use |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Collect configurations in conf/submarine-sit.xml, common-utils/SubmarineConfiguration.java, and common-utils/SubmarineConfVars into Kubernetes Configmap.
What type of PR is it?
Improvement
What is the Jira issue?
https://issues.apache.org/jira/projects/SUBMARINE/issues/SUBMARINE-1261?filter=allissues
Questions: