Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(examples): fix examples uri for sqlite #30277

Merged
merged 2 commits into from
Oct 3, 2024

Conversation

villebro
Copy link
Member

@villebro villebro commented Sep 14, 2024

SUMMARY

The PR #25680 fixed the default sqlite connection string for the metastore connection so that it works correctly in an async use case. However, this fix was not applied to the Examples data URI, causing async access to fail.

TESTING INSTRUCTIONS

  1. Install a fresh local devenv using sqlite
  2. Enable async execution for the examples database
  3. Issue a select 1 on the examples database

ADDITIONAL INFORMATION

  • Has associated issue: SIP-143: [SIP-143] Global Async Task Framework #29839
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dosubot dosubot bot added the data:connect Namespace | Anything related to db connections / integrations label Sep 14, 2024
Copy link

codecov bot commented Sep 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.75%. Comparing base (76d897e) to head (09212c8).
Report is 829 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #30277       +/-   ##
===========================================
+ Coverage   60.48%   83.75%   +23.27%     
===========================================
  Files        1931      534     -1397     
  Lines       76236    38544    -37692     
  Branches     8568        0     -8568     
===========================================
- Hits        46114    32284    -13830     
+ Misses      28017     6260    -21757     
+ Partials     2105        0     -2105     
Flag Coverage Δ
hive 48.94% <100.00%> (-0.23%) ⬇️
javascript ?
mysql 76.72% <100.00%> (?)
postgres 76.81% <100.00%> (?)
presto 53.44% <100.00%> (-0.37%) ⬇️
python 83.75% <100.00%> (+20.27%) ⬆️
sqlite 76.26% <100.00%> (?)
unit 60.51% <100.00%> (+2.88%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@villebro villebro force-pushed the villebro/examples-sqlite-thread branch from cb32a31 to 1752d00 Compare September 14, 2024 18:46
Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, and restarting E2E failures, but I'm wondering if we need to update this in the tests too.
From superset/.github/workflows/superset-python-integrationtest.yml

  test-sqlite:
    runs-on: ubuntu-22.04
    env:
      PYTHONPATH: ${{ github.workspace }}
      SUPERSET_CONFIG: tests.integration_tests.superset_test_config
      REDIS_PORT: 16379
      SUPERSET__SQLALCHEMY_DATABASE_URI: |
        sqlite:///${{ github.workspace }}/.temp/superset.db?check_same_thread=true
      SUPERSET__SQLALCHEMY_EXAMPLES_URI: |
        sqlite:///${{ github.workspace }}/.temp/examples.db?check_same_thread=true

To take it one step further, is there even a case for check_same_thread=true any more, or can we whittle some code away?

@rusackas rusackas merged commit 6217cb6 into apache:master Oct 3, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:connect Namespace | Anything related to db connections / integrations size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants