feat(controlPanel): add integer validation for rows per page setting

[ompharate]

fixes #36258

Root Cause

The server_page_length control configuration lacked the validators array that the row_limit control had, specifically missing the legacyValidateInteger validator.

Fix Applied

Added [validators: [legacyValidateInteger] to the server_page_length

Before

After

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[bito-code-review]

Code Review Agent Run #eb5065

Actionable Suggestions - 0

Review Details

• Files reviewed - 2 · Commit Range: b4071bd..b4071bd

  • superset-frontend/plugins/plugin-chart-ag-grid-table/src/controlPanel.tsx
  • superset-frontend/plugins/plugin-chart-table/src/controlPanel.tsx
• Files skipped - 0
• Tools

  • Whispers (Secret Scanner) - ✔︎ Successful
  • Detect-secrets (Secret Scanner) - ✔︎ Successful

---

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

• /review - Manually triggers a full AI review.

• /pause - Pauses automatic reviews on this pull request.

• /resume - Resumes automatic reviews.

• /resolve - Marks all Bito-posted review comments as resolved.

• /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Default Agent You can customize the agent settings here or contact your Bito workspace admin at [email protected].

Documentation & Help

• Customize agent settings
• Review rules
• General documentation
• FAQ

AI Code Review powered by

[rusackas]

This is awesome, thanks! However, perhaps we should use validateInteger rather than the legacy version.

[ompharate]

@rusackas
I have replaced legacyValidateInteger with validateInteger in both the Server Page Length and Row Limit controls across both table plugins (plugin-chart-table and plugin-chart-ag-grid-table) to keep the validation consistent.
Could you please review this change?