Skip to content

[WiP] docs: plug the Hello World plugin #8333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[WiP] docs: plug the Hello World plugin #8333

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions superset/assets/src/visualizations/presets/MainPreset.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ import SunburstChartPlugin from '@superset-ui/legacy-plugin-chart-sunburst';
import TableChartPlugin from '@superset-ui/legacy-plugin-chart-table';
import TreemapChartPlugin from '@superset-ui/legacy-plugin-chart-treemap';
import WordCloudChartPlugin from '@superset-ui/legacy-plugin-chart-word-cloud';
import HelloWorldPlugin from '@superset-ui/plugin-chart-hello-world/src';
import WorldMapChartPlugin from '@superset-ui/legacy-plugin-chart-world-map';
// There is a known issue with bubble chart that the bubbles will not show up.
// (<path d="NaN" />)
Expand Down Expand Up @@ -100,6 +101,7 @@ export default class MainPreset extends Preset {
new TimeTableChartPlugin().configure({ key: 'time_table' }),
new TreemapChartPlugin().configure({ key: 'treemap' }),
new WordCloudChartPlugin().configure({ key: 'word_cloud' }),
new HelloWorldPlugin().configure({ key: 'hello_world' }),
new WorldMapChartPlugin().configure({ key: 'world_map' }),
],
});
Expand Down
5 changes: 5 additions & 0 deletions superset/viz.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -764,6 +764,11 @@ def query_obj(self):
return d


class HelloWorld(BaseViz):
Copy link
Member Author

@mistercrunch mistercrunch Oct 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason this appears to be necessary despite being in useLegacyApi: false, also the content of buildQuery doesn't seem used at this time

Copy link

@dleclere dleclere Feb 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just lost a lot of time coming to this realisation :(

Copy link

@Smilebags Smilebags Apr 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Me too. This is a really sad limitation, if only this wasn't required, adding visualisations could be much simpler and more isolated.

viz_type = "hello_world"
pass


class TreemapViz(BaseViz):

"""Tree map visualisation for hierarchical data."""
Expand Down