Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINOR] Add DataTypes on memory estimates for HOPS #2221

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Baunsgaard
Copy link
Contributor

This commit changes the memory estimates of many of the HOPS, to include the datatype, Indicating if the output is a frame or a Matrix. It is included because I had to make one modification to a unary Op in BWARE, and in general, it does not hurt to add to many of the Op Types (even if they do not return frame types at the moment)

This commit changes the memory estimates of many of the HOPS,
to include the datatype, Indicating if the output is a frame or a
Matrix. It is included because I had to make one modification to a
unary Op in BWARE, and in general, it does not hurt to add to many of the
Op Types (even if they do not return frame types at the moment)
Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.45%. Comparing base (54c8696) to head (6a8a073).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2221   +/-   ##
=========================================
  Coverage     72.44%   72.45%           
- Complexity    45418    45426    +8     
=========================================
  Files          1469     1469           
  Lines        170840   170843    +3     
  Branches      33312    33312           
=========================================
+ Hits         123765   123782   +17     
+ Misses        37667    37654   -13     
+ Partials       9408     9407    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

None yet

1 participant